| Server IP : www.new.bangkokfinder.com / Your IP : 172.69.166.35 Web Server : nginx/1.20.1 System : Linux new 4.15.0-159-generic #167-Ubuntu SMP Tue Sep 21 08:55:05 UTC 2021 x86_64 User : bangkokfinder ( 1000) PHP Version : 7.4.33 Disable Function : pcntl_alarm,pcntl_fork,pcntl_waitpid,pcntl_wait,pcntl_wifexited,pcntl_wifstopped,pcntl_wifsignaled,pcntl_wifcontinued,pcntl_wexitstatus,pcntl_wtermsig,pcntl_wstopsig,pcntl_signal,pcntl_signal_get_handler,pcntl_signal_dispatch,pcntl_get_last_error,pcntl_strerror,pcntl_sigprocmask,pcntl_sigwaitinfo,pcntl_sigtimedwait,pcntl_exec,pcntl_getpriority,pcntl_setpriority,pcntl_async_signals,pcntl_unshare, MySQL : OFF | cURL : ON | WGET : ON | Perl : ON | Python : ON | Sudo : ON | Pkexec : ON Directory : /home/bangkokfinder/www/wp-content/plugins/wp-rocket/ |
Upload File : |
## ✅ PR Feedback Addressed | Feedback Item | Resolution | |--------------|------------| | **Remove compiled files from PR** | Reverted to develop - only source files included in commit | | **Unused PHP tracking methods** | Verified - tracking is JS-only, no PHP methods to remove | | **Move Mixpanel tracking** | Moved into `toggleSingleRowVisibility()` function | | **Only track expand, not collapse** | Now only tracks when showing (expand), not hiding (collapse) | | **Pass test ID to "See Report"** | Added `row_id: insightsId` to Mixpanel tracking | | **Move metric logic out of view** | Created `MetricFormatter` class with threshold constants and formatting methods | | **Remove duplicate blurred class** | Removed duplicate `$rocket_ri_blurred` from `row-right` div | | **Check duplicate method with PR #8009** | Not a duplicate - `parse_metric_data()` parses JSON from DB, `get_formatted_metrics()` formats for display | ### Files Changed - **New**: `inc/Engine/Admin/RocketInsights/MetricFormatter.php` - Centralized metric formatting logic - **Modified**: `inc/Engine/Admin/RocketInsights/Render.php` - Added MetricFormatter dependency injection - **Modified**: `inc/Engine/Admin/RocketInsights/ServiceProvider.php` - Registered `ri_metric_formatter` - **Modified**: `src/js/global/ajax.js` - Fixed Mixpanel tracking placement and behavior - **Modified**: `views/settings/partials/rocket-insights/table-row.php` - Simplified to use pre-formatted metrics